Re: Skytools committed without hackers discussion/review

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Marko Kreen <markokr(at)gmail(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 17:29:45
Message-ID: 20304.1192037385@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

"Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
> If it doesn't need to be in core, in certainly has zero need to be in
> contrib and can push to pgFoundry.

One advantage of having it in contrib is buildfarm testing, as indeed we
already found out ... although it's true that *keeping* it there now
that it passes probably won't teach us too much more.

But I think the argument that was being made was mostly that the Slony
and Skytools projects would find it easier to depend on a contrib module
than on something that has to be fetched separately from pgfoundry.
Now they could work around that by including copies of the pgfoundry
project in their own distributions, but then they have a collision
problem if someone tries to install both together. (I have no idea how
likely that is, though; it might not be a big problem in practice?)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2007-10-10 17:47:15 Re: Skytools committed without hackers discussion/review
Previous Message Greg Smith 2007-10-10 17:28:29 Re: pg_standby location (was added the Skytools extended transaction ID module)

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-10-10 17:47:15 Re: Skytools committed without hackers discussion/review
Previous Message Greg Smith 2007-10-10 17:28:29 Re: pg_standby location (was added the Skytools extended transaction ID module)