Re: A latent pointer increment bug in pgtypes_defmt_scan()

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: hlinnaka(at)iki(dot)fi
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: A latent pointer increment bug in pgtypes_defmt_scan()
Date: 2026-11-20 00:48:16
Message-ID: 20261120.094816.1945103660636381131.horikyota.ntt@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

At Thu, 19 Nov 2026 12:38:00 +0200, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote in
> With the skipping in PGTYPEStimestamp_defmt_scan(), all of those other
> snippets are redundant.
>
> This code could use some love, but I just committed your one-line fix
> for now.

Thanks for committing the fix.

I agree that those snippets are redundant, but I preferred to keep the
function self-contained. Further cleanup would involve the caller as
well, and I don't think it's worth the effort for now.

Regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Jeff Davis 2026-11-20 00:47:26 Re: Hash aggregate collisions cause excessive spilling