Re: [PATCH] reindexdb: Fix schema name lookup in parallel mode

Hi Koshi,

Thanks for v2.

I tested it on master, Debian bookworm container, built with
--enable-cassert --enable-debug --enable-tap-tests.
- v2 applies cleanly, and the build has no warnings.
- t/090_reindexdb.pl: 71 tests, PASS.
- With only the test changes from v2 and the old reindexdb.c, 4 tests fail:
the unquoted mixed-case schema, the quoted "S1x" schema, and the exit code
and output of the empty plus nonexistent schema case. So the new tests
catch the bug.

Keeping the comment as it is sounds fine to me.

About the backpatch: the same "ns.nspname IN (...)" lookup is on
REL_15_STABLE, REL_16_STABLE and REL_17_STABLE, so the bug is there too. v2
applies cleanly to REL_18_STABLE. It does not apply to 17, 16 and 15,
because the loop that builds the list is a little different there (it uses
nsp_listed), and the test file has moved a bit. The change itself is the
same two lines, so the port should be small. I have not built or tested it
on those branches.

I think the patch is ready for committer.

Regards,
Joao Rito