| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | jian(dot)universality(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: nodeWindowAgg.c IGNORE NULLS abs overflow |
| Date: | 2026-10-22 09:14:19 |
| Message-ID: | 20261022.181419.760195537957160529.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jian,
> Hi.
>
> SELECT v,
> lead(v, -2147483648) OVER w AS respect_nulls,
> lead(v, -2147483648) IGNORE NULLS OVER w AS ignore_nulls
> FROM (VALUES (1), (2)) AS t(v)
> WINDOW w AS (ORDER BY v);
>
> should return all NULL values for column ignore_nulls.
>
> The fix is to replace the abs function in nodeWindowAgg.c with pg_abs_s32.
Thank you for the report and the fix. Unfortunately I have no time to
take care this for now (till November 3rd). I will work on this after
November 4th unless someone beats me.
Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-10-22 09:18:02 | Re: PG19: two RI fast-path issues found while testing the batching revert |
| Previous Message | Amit Kapila | 2026-10-22 09:09:33 | Re: [PG19] Sequence sync stops when the subscription owner can't SET ROLE to a sequence owner |