| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, gonzalemario(at)gmail(dot)com, dbryan(dot)green(at)gmail(dot)com, euler(at)eulerto(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_get_*_ddl() needs a redesign |
| Date: | 2026-09-09 17:21:32 |
| Message-ID: | 20260909172132.0a.noahmisch@microsoft.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 09, 2026 at 12:24:32PM -0400, Andrew Dunstan wrote:
> On 2026-09-09 We 11:47 AM, Melanie Plageman wrote:
> > [RMT hat]
> >
> > We are concerned that there has been no reply addressing these
> > reported issues. We urge the feature authors to reply and determine
> > whether or not this feature needs to be fixed (or reverted).
>
> Sorry, my bad. Euler and I have been working on fixes, which I hope to
> publish today. There was a slight delay due to the issue addressed by my
> commit a12600b762c from an hour or so ago.
I want to clarify one thing before you spend much time on fixes. I don't see
"fixes" addressing this thread as a whole, unless you plan to dispute the
premise that the feature needs a redesign. In other words, I think the thread
outcome should be one of these:
- My review erred in determining that the feature needs a redesign. The
design is sound and should proceed, possibly with some fixes.
- Revert the feature.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-09-09 17:28:36 | Re: REPACK (CONCURRENTLY) rewrites tables marked with user_catalog_table |
| Previous Message | best xmg | 2026-09-09 17:18:58 | Hash a ScalarArrayOpExpr whose array is fixed for one execution |