Re: Adding volatile qualifer

>> While looking into the Pgpool-II main source code, I noticed that
>> local pointer array "my_backend_status" is not volatile qualified,
>> while it should have been.
>>
>> BACKEND_STATUS *my_backend_status[MAX_NUM_BACKENDS]; /* Backend status buffer */
>>
>> This array members are initialized:
>>
>> for (i = 0; i < MAX_NUM_BACKENDS; i++)
>> {
>> my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
>> }
>>
>> Without volatile, *(my_backend_status[i]) could read state value
>> because of compiler optimization. Since my_backend_status[i] is
>> referred to in popular VALID_BACKEND macro, we should fix it in all
>> supported branches.
>
> volatile qualifier should have been attached to the right hand side
> too. Attached v2 patch does it.

v2 patch pushed to all supported branches.
https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=c2d464521ef017fd7aa76fc56c412c5af06fdb07

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp