| From: | Zakariyah Ali <zakariyahali100(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Zakariyah Ali <zakariyahali100(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Fix missing-field-initializers and sign comparison warnings |
| Date: | 2026-06-19 13:26:44 |
| Message-ID: | 20260619132644.111725-1-zakariyahali100@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tom, Peter,
The warnings for the `ErrorSaveContext` and the `pg_dependencies_out()` loop counter were observed with GCC using the `-Wmissing-field-initializers` and `-Wsign-compare` flags.
However, I completely understand the concern that these warnings are not part of PostgreSQL's currently supported warning set. I agree that making code changes (like switching to designated initializers or changing loop types) just to satisfy these non-default flags isn't the right approach without a project-wide consensus to enforce them.
Given that, I will drop this patch. Thank you both for your time, the reviews, and the insights into how the project handles compiler warnings!
Best regards,
Zakariyah
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nishant Sharma | 2026-06-19 13:28:09 | Re: Show hashed SAOP decision in EXPLAIN |
| Previous Message | Nikhil Shetty | 2026-06-19 13:26:22 | Re: Proposal: Conflict log history table for Logical Replication |