| From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adjust error message for CREATE STATISTICS to account for expressions |
| Date: | 2026-04-03 01:44:53 |
| Message-ID: | 20260403104453.ae4e81b0821533045b0520a4@sraoss.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 1 Apr 2026 17:19:16 +0100
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> On Tue, 31 Mar 2026 at 15:47, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> >
> > Yes, that sounds good to me.
> >
> > In particular, the following suggestion from Dean Rasheed seems like a
> > good approach:
> >
> > > Error: cannot create extended statistics on a single column
> > > Detail: Univariate statistics are already built for each individual
> > > table column
>
> I've pushed that change as part of the patch to support extended
> statistics on virtual generated columns [1], since I felt that patch
> already needed to change that error message.
Thank you for handling this.
> I didn't look more widely at other error messages in that file might
> benefit from having separate errdetail text.
I’ve attached a patch that also updates other error messages to move
their reason parts into errdetail.
Regards,
Yugo Nagata
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
| Attachment | Content-Type | Size |
|---|---|---|
| v3-Adjust_error_message_for_CREATE_STATISTICS.patch | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-04-03 01:53:54 | Re: SQL/PGQ: All properties reference |
| Previous Message | Tom Lane | 2026-04-03 01:11:22 | Re: pg_waldump: support decoding of WAL inside tarfile |