Re: Adding REPACK [concurrently]

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Adding REPACK [concurrently]
Date: 2026-04-02 08:27:21
Message-ID: 202604020825.agnq44uixbwk@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Apr-02, Srinath Reddy Sadipiralla wrote:

> On Sat, Mar 28, 2026 at 12:12 AM Srinath Reddy Sadipiralla <
> srinath2133(at)gmail(dot)com> wrote:
>
> > Hi Alvaro,
> >
> >> I don't disagree with changing this, but AFAICS the patch as presented
> >> provokes multiple test failures.
> >
> > Fixed with the attached patch.
>
> Just want to remind about this patch.

Yeah, it doesn't apply anymore. I rebased it some time ago, but it
still failed a few tests -- I'm guessing you don't have either TAP tests
or injection points enabled, which would explain why you don't see those
failures. So please rebase it against v49, but also look into making it
pass all tests (I suggest making it go through CI).

Thanks,

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"We’ve narrowed the problem down to the customer’s pants being in a situation
of vigorous combustion" (Robert Haas, Postgres expert extraordinaire)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-04-02 08:33:09 Re: DOC: pg_publication_rel.prrelid says sequences are possible
Previous Message Jim Jones 2026-04-02 08:12:31 Re: [PATCH] Add CANONICAL option to xmlserialize