Re: Improve pgindent's formatting named fields in struct literals and varidic functions

On 2026-Mar-31, Andreas Karlsson wrote:

> On 3/31/26 9:16 AM, Jelte Fennema-Nio wrote:
> > On Tue, 31 Mar 2026 at 08:30, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> > > Rebased it again.
> >
> > I agree this looks better. So seems like a reasonable improvement.
>
> Thanks for taking a look!
>
> But noticed now that the tests were broken so here is a new version where
> they pass and where I also added a new test case for struct literals with
> named fields.

Hmm, interesting, I've wondered why variadic functions had such a weird
indentation and this explains it. I also +1 this, but at the same time
I think the best time to get it in is a few weeks after the feature
freeze. That way we minimize the impact on any fixes during the
stabilization period. I'm not sure at what point relative to the betas
though; is it better to do it before, so that we have a chance to fix
any possible problems before they hit users, or is it better to do after
beta1, so that patches that we discover need reverting for pg19 have
already had a chance to be so?

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/