Re: pg_publication_tables: return NULL attnames when no column list is specified

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Roberto Mello <roberto(dot)mello(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified
Date: 2026-03-26 12:37:19
Message-ID: 202603261226.uo54xj4rpex2@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Mar-25, Roberto Mello wrote:

> The problem is that pg_get_publication_tables() in pg_publication.c
> (the set-returning function backing the pg_publication_tables view)
> erases this distinction. When prattrs is NULL, it opens the table,
> iterates all eligible attributes, and builds a synthetic int2vector of
> all current columns. The view then shows the same attnames output for
> both cases.

I agree that this is wrong. This distinction was explicitly discussed
when the column-list feature was developed. I don't think we can
backpatch the fix though, out of fear that we would break something for
existing users; but we should definitely fix it for pg19.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"But static content is just dynamic content that isn't moving!"
http://smylers.hates-software.com/2007/08/15/fe244d0c.html

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2026-03-26 12:46:27 RE: Initial COPY of Logical Replication is too slow
Previous Message Heikki Linnakangas 2026-03-26 12:16:52 Clean up NamedLWLockTranche stuff