| From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Track skipped tables during autovacuum and autoanalyze |
| Date: | 2026-03-26 01:18:39 |
| Message-ID: | 20260326101839.b186bdc5afc8d883c6a49262@sraoss.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 26 Mar 2026 08:26:26 +0900
Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Mar 25, 2026 at 12:12:35PM -0500, Sami Imseih wrote:
> > I'm fine with adding timestamps, as there seem to be convincing
> > reasons to add them.
> > My other concern is bloat of the pg_stat_all_tables view. This patch
> > adds 4 columns, or
> > 8 if we also include manual vacuum and analyze (which I think we should).
> >
> > Given that, should we also start thinking about splitting the vacuum
> > activity related
> > columns into a dedicated view and out of pg_stat_all_tables for v20?
>
> PgStat_StatTabEntry is shared between indexes and tables. A bunch of
> its fields apply only to tables, not indexes (aka all the vacuum and
> analyze ones). Few fields apply only to indexes, not tables. Not
> that many are shared between both. I would advocate for a clean split
> between indexes and tables, as a start, with a new variable-sized
> stats kind dedicated to indexes.
I see that the following fields are used in pg_stat_all_indexes:
- numscans
- lastscan
- tuples_returned
- tuples_fetched
- stat_reset_time
but they are also shared with pg_stat_all_tables. Are you suggesting
splitting these shared fields from those that are specific to tables?
I'm not sure this would significantly reduce the size of
PgStat_StatTabEntry. Could you elaborate on the expected benefits?
Regards,
Yugo Nagata
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-03-26 01:21:38 | Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions |
| Previous Message | Lukas Fittl | 2026-03-26 01:17:44 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |