| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
| Cc: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2026-03-24 22:32:17 |
| Message-ID: | 202603242222.5i7awkn7jpdr@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 2026-Mar-20, Mihail Nikalayeu wrote:
> Hello, everyone!
>
> Some comments for v43:
Many thanks for the review. I have applied fixes for these, so here's
v44. Changes:
- 0001 now simply renames the existing function and adds the
"concurrently" flag, instead of adding a separate function. I don't
think there's a reason to keep the previous function name.
- 0002 is unchanged.
- 0003 contains the fixes to the problems pointed out by Mihail;
otherwise it's pretty much the same as in v43.
- 0004 is Antonin's bugfix from the crash reported by Srinath.
- 0005 to 0007 are my proposed changes on this round. It's mostly just
cosmetics. I intend to squash these all into a single commit (0003 to
at least 0007) when posting the next version.
- 0008 to 0010 are as posted by Antonin; they are unchanged, except for
fixes for the problems pointed out by Mihail. Antonin, I would
appreciate it if you want to change the "reform" bit in 0007 as
discussed.
For the next version I'll probably also rename the file cluster.c to
repack.c as well as assorted symbols therein, as well as studying the
coverage more closely.
Thanks,
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v44-0001-Make-index_concurrently_create_copy-more-general.patch | text/x-diff | 9.4 KB |
| v44-0002-Do-not-dereference-varattrib_4b-in-VARSIZE_4B.patch | text/x-diff | 1.9 KB |
| v44-0003-Add-CONCURRENTLY-option-to-REPACK-command.patch | text/x-diff | 179.4 KB |
| v44-0004-Fix-crash-caused-by-involuntary-decoding-of-unre.patch | text/x-diff | 2.0 KB |
| v44-0005-Rename-ChangeDest-to-ChangeContext-and-absorb-In.patch | text/x-diff | 21.1 KB |
| v44-0006-rename-routines-on-the-logical-output-plugin-sid.patch | text/x-diff | 6.1 KB |
| v44-0007-Split-cluster.h-to-create-repack_internal.h.patch | text/x-diff | 16.9 KB |
| v44-0008-Use-BulkInsertState-when-copying-data-to-the-new.patch | text/x-diff | 6.7 KB |
| v44-0009-Fix-a-few-problems-in-index-build-progress-repor.patch | text/x-diff | 8.3 KB |
| v44-0010-Teach-snapshot-builder-to-skip-transactions-runn.patch | text/x-diff | 19.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2026-03-24 22:47:47 | Re: [19] CREATE SUBSCRIPTION ... SERVER |
| Previous Message | Zsolt Parragi | 2026-03-24 22:21:19 | Re: Add GoAway protocol message for graceful but fast server shutdown/switchover |