| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | assam258(at)gmail(dot)com |
| Cc: | zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Row pattern recognition |
| Date: | 2026-03-19 10:10:35 |
| Message-ID: | 20260319.191035.328225166092779523.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Henson,
>> Got it, thanks. By the way, how about splitting the test patch
>> into two -- one for sql + data files and another for expected
>> output files? The single test patch is getting quite large and
>> cfbot often fails to apply it.
>
> Sounds like a good idea.
I have made an estimate how large each patch part is.
SQL + data patches:
src/test/regress/sql/rpr.sql | 1164 ++++
src/test/regress/sql/rpr_base.sql | 3986 +++++++++++++
src/test/regress/sql/rpr_explain.sql | 2296 ++++++++
src/test/regress/sql/rpr_nfa.sql | 3278 +++++++++++
src/test/regress/parallel_schedule | 5 +
src/test/regress/data/stock.data | 1632
-----------------------------------------------------
total 12361
Expected patches:
src/test/regress/expected/rpr.out | 2356 ++++++++
src/test/regress/expected/rpr_base.out | 6202 +++++++++++++++++++++
src/test/regress/expected/rpr_explain.out | 3968 +++++++++++++
src/test/regress/expected/rpr_nfa.out | 4340 ++++++++++++++
-----------------------------------------------------
total 16866
It seems we will have about 12k (sql and data) and 16k (expected)
patches. Looks nice balance.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-03-19 10:16:05 | Re: pg_stat_io_histogram |
| Previous Message | Peter Eisentraut | 2026-03-19 10:09:26 | Re: Read-only connection mode for AI workflows. |