| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: some more include removal from headers |
| Date: | 2026-03-16 13:42:09 |
| Message-ID: | 202603161336.o4l2wmcf5rc5@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I pushed this now, after also removing the #include instrument.h from
execnodes.h.
One I purposefully didn't remove from execnodes is reltrigger.h, though
it's quite an easy change. I think what we should do here is rethink
the relationship between rel.h, trigger.h and reltrigger.h. It looks
weird to me that structs like TriggerData (used for firing triggers) are
in a header file under src/include/commands. Maybe revert b93f5a5673b4
entirely.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Pido que me den el Nobel por razones humanitarias" (Nicanor Parra)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-03-16 13:46:02 | Re: Adding REPACK [concurrently] |
| Previous Message | Jelte Fennema-Nio | 2026-03-16 13:40:52 | Re: Change copyObject() to use typeof_unqual |