Re: Fix array access (src/bin/pg_dump/pg_dump.c)

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix array access (src/bin/pg_dump/pg_dump.c)
Date: 2026-03-07 13:33:08
Message-ID: 202603071332.763hisfhn45h@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Nov-12, Ranier Vilela wrote:

> Em ter., 12 de nov. de 2024 às 16:11, Alvaro Herrera <
> alvherre(at)alvh(dot)no-ip(dot)org> escreveu:
>
> > On 2024-Nov-12, Ranier Vilela wrote:
> >
> > > Per Coverity.
> > >
> > > The function *determineNotNullFlags* has a little oversight.
> > > The struct field *notnull_islocal* is an array.
> > >
> > > I think this is a simple typo.
> > > Fix using array notation access.
> >
> > Yeah, thanks, I had been made aware of this bug. Before fixing I'd like
> > to construct a test case that tickles that code, because it's currently
> > uncovered *shudder*
>
> Thanks for taking care of this.

Fixed, thanks.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Evgeny Voropaev 2026-03-07 13:56:18 Compress prune/freeze records with Delta Frame of Reference algorithm
Previous Message Álvaro Herrera 2026-03-07 13:32:18 Re: [BUG?] missing array index may result in a wrong constraint name (pg_dump, bin-upgrade, >=18)