Re: [PATCH] Downgrade elog(LOG) to elog(DEBUG1) for pi->node_ids in get_pools()

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: yishaitamir(at)live(dot)com
Cc: pgpool-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Downgrade elog(LOG) to elog(DEBUG1) for pi->node_ids in get_pools()
Date: 2026-03-05 04:16:02
Message-ID: 20260305.131602.968371260826527447.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-hackers

> Hi,
>
> The attached patch downgrades an elog(LOG) to elog(DEBUG1) in get_pools()
> (src/utils/pool_process_reporting.c).
>
> The elog statement was added in commit 706ca859c as part of the
> pgpool_adm_pcp_proc_info feature. It prints pi->node_ids bitmap values
> at LOG level for every connection on every backend whenever pool status
> is queried.
>
> In containerized deployments where a metrics exporter (pgpool2_exporter)
> continuously polls "show pool_pools", this produces thousands of log
> lines per minute. We confirmed the fix eliminates the spam on our
> staging cluster under real production-like traffic.
>
> Since the message is purely diagnostic, DEBUG1 is the appropriate level.
>
> GitHub issue: https://github.com/pgpool/pgpool2/issues/153

Thanks for the patch. I have already pushed a very similar patch
created by me.
https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=f647c4a372ea2c2cfae80e4e60f209e236fe41ec

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgpool-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-03-09 05:18:39 Re: Proposal: Recent mutated table tracking in memory
Previous Message Yishai Tamir 2026-03-04 18:39:27 [PATCH] Downgrade elog(LOG) to elog(DEBUG1) for pi->node_ids in get_pools()