Re: pgstat include expansion

From: Alvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: pgstat include expansion
Date: 2026-02-26 17:40:08
Message-ID: 202602261733.s2rkxezwuif6@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Feb-26, Andres Freund wrote:

> I'm not sure that including in latch.h really would an improvement though -
> that's included in proc.h and libpq.h, which both are fairly widely included
> [1].

Although we cannot remove latch.h, what we can do is remove proc.h from
shm_mq.h, which is actually very good because the proliferation of stuff
from there is enormous. See the attached. Practically all the network
of dependents of proc.h comes from there. The fallout is even somewhat
insane. I think this is a good cleanup.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Industry suffers from the managerial dogma that for the sake of stability
and continuity, the company should be independent of the competence of
individual employees." (E. Dijkstra)

Attachment Content-Type Size
0001-Avoid-including-proc.h-in-shm_mq.h.patch text/x-diff 13.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2026-02-26 18:06:59 Re: Show expression of virtual columns in error messages
Previous Message Alvaro Herrera 2026-02-26 17:07:43 Re: pgstat include expansion