Re: Fix bug of clearing of waitStart in ProcWakeup()

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: ji xu <thanksgreed(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Fix bug of clearing of waitStart in ProcWakeup()
Date: 2026-02-24 16:12:41
Message-ID: 202602241611.fycyz33zer3r@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Feb-24, ji xu wrote:

> Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> 于2026年2月24日周二 14:29写道:
>
> > ```
> > PGPROC *
> > ProcWakeup(PGPROC *proc, ProcWaitStatus waitStatus)
> > {

> > pg_atomic_write_u64(&MyProc->waitStart, 0); <== Here, it should
> > operate on proc

I agree that this looks wrong. AFAICS it comes from 46d6e5f56790.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
[…] indem ich in meinem Leben oft an euch gedacht, euch glücklich zu machen. Seyd es!
A menudo he pensado en vosotros, en haceros felices. ¡Sedlo, pues!
Heiligenstädter Testament, L. v. Beethoven, 1802
https://de.wikisource.org/wiki/Heiligenstädter_Testament

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2026-02-24 16:13:02 New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering
Previous Message Peter Eisentraut 2026-02-24 16:05:34 Re: Don't cast away const where possible