| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | assam258(at)gmail(dot)com |
| Cc: | vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Row pattern recognition |
| Date: | 2026-02-24 05:09:27 |
| Message-ID: | 20260224.140927.1828965853586507533.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Henson,
>> BTW, in create_windowagg_plan (createplan.c),
>> around:
>> /* Build RPR pattern and filter defineClause */
>>
>> collectPatternVariables, filterDefineClause and buildRPRPattern are
>> called in a block without any if or any other conditional
>> statements. This is an unusual codiing style in PostgreSQL. I suggest
>> to fix this. Attached is a proposed patch for this.
>
> Good catch, thank you! I've renumbered your patch as nocfbot-0007
> and extended the same cleanup to rpr.c and parse_rpr.c as
> nocfbot-0008.
>
> nocfbot-0007: Refactor create_windowagg_plan to remove bare
> variable-scoping block (your patch, renumbered)
>
> nocfbot-0008: Remove bare variable-scoping blocks in RPR code
>
> Applies the same cleanup to rpr.c and parse_rpr.c, with minor
> pgindent formatting fixes.
>
> I'll keep this coding style point in mind for future code as well.
Thank you for quick response!
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-02-24 05:36:15 | Re: [PATCH] Support automatic sequence replication |
| Previous Message | Manni Wood | 2026-02-24 04:44:44 | Re: Speed up COPY FROM text/CSV parsing using SIMD |