| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Headerscheck support for meson |
| Date: | 2026-02-17 17:40:59 |
| Message-ID: | 202602171734.mc5ku3dx2tg5@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Feb-17, Andres Freund wrote:
> I also think that eventually we should do what you alluded to in a comment,
> namely make headerscheck an explicit part of the build system, with proper
> support for dependencies and parallelism.
How would that work? I imagine that there would be a script or program
that takes a single .h file as argument and returns OK or fail for it;
then meson knows to run that script once for every .h file in the tree.
How to construct the list of files might also be a separate simple
script that just does "git ls-files *.h" then filters out the files we
know can't pass the compile.
Would it make sense to split our current script into a bunch of smaller
ones that each does one of these things, so that they can be reused by
a Meson target in a way that's more convenient? In Make we would just
call some wrapper script that simply calls the others to do the full job
in a single pass, the way it is now.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Always assume the user will do much worse than the stupidest thing
you can imagine." (Julien PUYDT)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-02-17 17:49:10 | Re: Headerscheck support for meson |
| Previous Message | Nathan Bossart | 2026-02-17 17:35:43 | Re: Proposal: ANALYZE (MODIFIED_STATS) using autoanalyze thresholds |