Re: Row pattern recognition

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: assam258(at)gmail(dot)com
Cc: jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-01-17 08:18:50
Message-ID: 20260117.171850.1962296273462570705.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Henson,

> I'm now reviewing the remaining parts: pattern optimization in planner,
> absorption function, and step function. Once the review is complete,
> I'll send the rest of the patches.

I am reviewing the test cases and found this:

SELECT * FROM (SELECT 1 AS x) t
WINDOW w AS (
ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING
PATTERN (a b c d e f g h i j k l m n o p q r s t u v w x y z aa)
DEFINE a AS TRUE
);
ERROR: number of row pattern definition variable names exceeds 26

I thought you have eliminated the 26 variables limit. If so, related
codes using WindowClause->defineInitial should be removed. Shall I do
that? Or you want to do that while refactoring?

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-01-17 08:33:28 Re: Row pattern recognition
Previous Message Aditya Gollamudi 2026-01-17 05:14:06 [PATCH] PASSING clause documentation fix