Re: Can we change pg_rewind used without wal_log_hints and data_checksums

From: Movead <lchch1990(at)sina(dot)cn>
To: "Laurenz Albe" <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Can we change pg_rewind used without wal_log_hints and data_checksums
Date: 2026-01-16 13:28:28
Message-ID: 2026011621281888755416@sina.cn
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

As discussed on the other mail thread:
https://www.postgresql.org/message-id/696885c3db9be6.68269280.fb0eaf68%40m0.mail.sina.com.cn

I need to do two changes on the patch.
1. Find some way to handle static variables.
2. Do not collect useless pages on the third step.

For the first one because the static variables needed on several place and it seem worst if
deliver by function parameters, so I keep them.

For the second one I have tryied to keep a commited transaction ID list or bitmapset, however
the data structs seem hard to use in src/bin code. So I use min_commited_xid and
max_commited_xid instead to filter the useless pages.

In fact the min_commited_xid and max_commited_xid is the edge transaction commited after
diverge record, so it's enough.

Changed patch attached.

----
Best Regards,
Movead Li

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

Attachment Content-Type Size
0001-pg_rewind_enhance.patch application/octet-stream 15.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2026-01-16 13:50:18 RE: Simplify code building the LR conflict messages
Previous Message Hunaid Sohail 2026-01-16 13:14:56 Re: Proposal: SELECT * EXCLUDE (...) command