Re: Add IS_INDEX macro to brin and gist index

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add IS_INDEX macro to brin and gist index
Date: 2026-01-16 08:55:15
Message-ID: 202601160852.fadepjixu32p@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Jan-16, Japin Li wrote:

> Thanks for the test. After rethinking, I agree — that BRIN/GIST index-type
> check is useless.
>
> OTOH, why don't we just do it the same way as the btree index functions?
>
> brin_page_items(relname text, blkno bigint);

Operational usefulness. If you have a corrupt page in a production, you
can extract it from there with get_raw_page() and move it to another
system to do low-level investigation. If you only have the interface
you suggest, you force the researcher to access the production system
(and run potentially dangerous tools), which may be best avoided.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Anthonin Bonnefoy 2026-01-16 09:10:07 Re: Add missing JIT inline pass for llvm>=17
Previous Message Zsolt Parragi 2026-01-16 08:30:50 Re: Custom oauth validator options