Re: remove the unneeded header file math.h in binaryheap.c

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: liujinyang <21043272(at)qq(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: remove the unneeded header file math.h in binaryheap.c
Date: 2026-01-13 17:18:19
Message-ID: 202601131402.kjp7ceoxgr44@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Jan-13, liujinyang wrote:

> Hi Hackers,
>
> I found in file binaryheap.c， file "math.h" was included, but it is uncessary, so I removed it&nbsp;
> and filing a patch to address the issue.

Fun. This was already unnecessary at commit 7a2fe9bd0371 which
introduced the file. It seems Abhijit had that include in his first
version [1] because he was using floor(). Robert rewrote it later [2]
and replaced that with straight arithmetic, making the include
unnecessary, but forgot to remove it.

[1] https://postgr.es/m/20121114131112.GA27771@toroid.org
[2] https://postgr.es/m/CA%2BTgmobvR7XW9fjj2RNY7sKK-VAG5nahfai_zV51rHVLDNvaBg%40mail.gmail.com

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-01-13 17:24:46 Re: how to gate experimental features (SQL/PGQ)
Previous Message Jacob Champion 2026-01-13 16:49:06 Re: how to gate experimental features (SQL/PGQ)