| From: | Michael Banck <mbanck(at)gmx(dot)net> |
|---|---|
| To: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, VASUKI M <vasukianand0119(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, melanieplageman(at)gmail(dot)com, juanjo(dot)santamaria(at)gmail(dot)com |
| Subject: | Re: [PATCH] Expose checkpoint reason to completion log messages. |
| Date: | 2026-01-07 08:07:18 |
| Message-ID: | 20260107080717.GA21237@p46.dedyn.io;lightning.p46.dedyn.io |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Jan 07, 2026 at 12:35:08PM +0530, Soumya S Murali wrote:
> I agree with your point that the checkpoint completion message should
> use the same terminology as the starting message ( “fast” rather than
> “immediate”) and I have updated the patch accordingly and have
> attached herewith for review. This patch aligns the checkpoint
> completion log wording with the existing checkpoint starting message
> (using “fast” instead of “immediate”) for consistency.
First off, please send complete and not incremental patches.
From what I can tell, you currently also do not have "wal" as reason?
Also, you have "timed" vs "time" etc.
I think it would make most sense to factor out the logic for the
starting checkpoint reason from xlog.c ("(errmsg("checkpoint
starting:%s%s%s%s%s%s%s%s")") and use that both for starting and
stopping.
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-07 08:14:38 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | Alexander Korotkov | 2026-01-07 08:06:23 | Re: Implement waiting for wal lsn replay: reloaded |