Re: [PATCH] Expose checkpoint reason to completion log messages.

From: Michael Banck <mbanck(at)gmx(dot)net>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, melanieplageman(at)gmail(dot)com, juanjo(dot)santamaria(at)gmail(dot)com
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.
Date: 2026-01-06 10:38:47
Message-ID: 20260106103847.GB30363@p46.dedyn.io;lightning.p46.dedyn.io
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Jan 06, 2026 at 02:41:16PM +0900, Fujii Masao wrote:
> On Thu, Jan 1, 2026 at 5:09 PM Soumya S Murali
> <soumyamurali(dot)work(at)gmail(dot)com> wrote:
> > On Thu, Dec 18, 2025 at 5:49 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > On 2025-12-01 16:48:56 +0530, Soumya S Murali wrote:
> > > > This patch is an update after reworking the “checkpoint reason” changes as
> > > > a standalone patch, separate from the pg_stat_checkpointer additions as
> > > > suggested [1].
>
> This kind of information already seems to be included in the
> checkpoint starting log message, for example:
>
> LOG: checkpoint starting: fast force wait
>
> Why do you want to include essentially the same information in the
> checkpoint ending log message as well?

I do think it is useful; the checkpoint finished message has a lot more
information than the checkpoint starting meessage (which basically only
mentions the reason) and when you extract log messages you currently
need to backtrack from the checkpoint finished message to the
corresponding checkpoint starting message to find out the type. Seeing
how the checkpoint finished message is so much more verbose anyway, I
think adding the reason to it is reasonably and helpful.

Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message zengman 2026-01-06 10:46:48 Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ...
Previous Message Japin Li 2026-01-06 10:16:02 Remove deprecated role membership options from psql help for CREATE USER/GROUP