| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: Implement waiting for wal lsn replay: reloaded |
| Date: | 2025-12-30 03:14:42 |
| Message-ID: | 202512300309.ob42gaafej7v@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Dec-27, Xuneng Zhou wrote:
> On Fri, Dec 26, 2025 at 4:25 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > 2 - 0002
> > ```
> > + else
> > + ereport(ERROR,
> > + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> > + errmsg("unrecognized value for WAIT option \"%s\": \"%s\"",
> > + "MODE", mode_str),
> > ```
> >
> > I wonder why don’t we directly put MODE into the error message?
>
> Yeah, putting MODE into the error message is cleaner. It's done in v8.
The reason not to do that (and also put WAIT in a separate string) is so
that the message is identicla to other messages and thus requires no
separate translation, specifically
errmsg("unrecognized value for %s option \"%s\": \"%s\"", ...)
See commit 502e256f2262. Please use that form.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"El sabio habla porque tiene algo que decir;
el tonto, porque tiene que decir algo" (Platon).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuya Kawata | 2025-12-30 03:23:24 | Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE |
| Previous Message | cca5507 | 2025-12-30 02:57:46 | Re: [BUG] Incorrect historic snapshot may be serialized to diskduring fast-forwarding |