Re: Propose: Adding a '--enable-failover' option to 'pg_createsubscriber'

thanks for your comment.

There are two failover variables, one is CreateSubscriberOptions.failover, the other is LogicalRepInfos.failover.
That comment is for LogicalRepInfos.failover.
LogicalRepInfos.failover variable is used when logical replication slot will be created for the subscription.

ioseph

On Wed, Dec 10, 2025 at 06:11:46PM +0800, 高雪玉 wrote:
> Hi,
> I have one comment to following comment:
>
>
> pg_createsubscriber.c, the comment is not correct as this new option is not related with logical replication slot.
> bool failover; /* enable failover option of logical replication slot */
>
>
> Suggest to change to:
> /* enable failover option of subscription */
>
>
> Thanks,
> Xueyu Gao
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
>
> At 2025-12-10 17:03:48, "Ioseph Kim" <pgsql-kr(at)postgresql(dot)kr> wrote:
> >Hi
> >
> >A failover option has been added to the CREATE SUBSCRITION command, but this functionality isn't easily accessible using the pg_createsubscriber tool.
> >
> >Subscriptions created using pg_createsubscriber must be configured for failover via an alter operation.
> >
> >To address this issue, we've added a simple --enable-failover option to the pg_createsubscriber tool.
> >
> >This patch is simple. It doesn't handle exceptions or provide any TAP test code.
> >
> >Please review this and we hope the development team will refine it further.
> >
> >ioseph