Re: quoteOneName() inconsistency with quote_all_identifiers — replacement API proposed

Hi,

> - appendStringInfo(&buffer, _("text search configuration %s"),
> - quote_qualified_identifier(nspname,
> - NameStr(cfgForm->cfgname)));
> + appendStringInfoQualifiedIdentifier(&buffer,
> + _("text search configuration "),
> + nspname, NameStr(cfgForm->cfgname), NULL);
> ReleaseSysCache(tup);
> break;
> }

This doesn't work from a i18n point of view. In the original
formulation, the translator is free to place the %s wherever it suits
the language. In the new one there's no such freedom: the name will be
appended at the end. Some existing translations:

ko.po:msgid "text search configuration %s"
ko.po-msgstr "%s 전문 검색 구성"

tr.po:msgid "text search configuration %s"
tr.po-msgstr "%s metin arama yapılandırması"

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"I must say, I am absolutely impressed with what pgsql's implementation of
VALUES allows me to do. It's kind of ridiculous how much "work" goes away in
my code. Too bad I can't do this at work (Oracle 8/9)." (Tom Allison)
http://archives.postgresql.org/pgsql-general/2007-06/msg00016.php