Re: Few untranslated error messages in OAuth

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Few untranslated error messages in OAuth
Date: 2025-11-13 08:13:40
Message-ID: 202511130803.y5k3yypn5323@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Nov-13, Zhijie Hou (Fujitsu) wrote:

> Hi,
>
> During testing of libpq, I noticed several error messages not processed by
> libpq_gettext, resulting in their exclusion from *.pot files. The attached patch
> wraps these messages.

Yeah, this roughly makes sense. I think the documentation for errctx in
async_ctx needs to be updated though, because currently it says "it'll
be translated for you" but this patch makes it the other way around (it
must come translated).

Alternatively, we could mark the strings with gettext_noop(), which only
adds the messages to the catalog without translating them; so the
responsibility of translating them would remain where it is today. This
might be easier.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"No tengo por qué estar de acuerdo con lo que pienso"
(Carlos Caszeli)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-11-13 08:20:41 Re: [PATCH] Add pg_get_subscription_ddl() function
Previous Message Chao Li 2025-11-13 08:13:30 Re: Suggestion to add --continue-client-on-abort option to pgbench