Re: Suggestion to add --continue-client-on-abort option to pgbench

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Date: 2025-11-12 07:47:03
Message-ID: 20251112164703.3bb280a5a8012e99888eb3da@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 12 Nov 2025 00:22:38 +0900
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Tue, Nov 11, 2025 at 11:41 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > I am also debugging the patch for the other purpose when I saw your email, so I tried to reproduce the problem with your script.
> >
> > I think in master branch, we can simply fix the problem by calling discardAvailableResults(st) before discardUntilSync(st), like this:
>
> This change doesn't seem to fix the issue. If the custom script includes
> many \syncpipeline commands, the assertion failure can still occur. No?

Yes. discardAvailableResults() does not discard all syncs, just until
NULL following the first sync, in pipeline mode without a connection failure.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-11-12 07:52:16 Re: Make PQgetResult() not return NULL on out-of-memory error
Previous Message jian he 2025-11-12 07:44:30 Re: [patch] ALTER COLUMN SET EXPRESSION [GENERATED|STORED]