| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Manni Wood <manni(dot)wood(at)enterprisedb(dot)com> |
| Cc: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement |
| Date: | 2025-11-12 16:15:46 |
| Message-ID: | 202511121601.bwhbqeo4owwu@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Nov-12, Manni Wood wrote:
> Thanks, Álvaro, for your continued help with this.
>
> I have attached v11 patches that use all of the fixes from your
> review.patch.txt.
OK, thanks, I pushed 0001 now.
I think you could claim that some routines currently in
src/backend/commands/tablespace.c logically belong in the new file, but
unless you want to take on the task of moving a lot of other routines
under commands/ to their respective catalog/ file, then I think it's
more or less fine as is.
To be clear, I do not intend to do anything with your 0002 patch [for
now]. I'm going to let Andrew take these DDL-producing functions in his
hands. Here I'm just posting your 0002 again, to make the cfbot happy.
Thanks
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Nunca se desea ardientemente lo que solo se desea por razón" (F. Alexandre)
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0002-Adds-pg_get_tablespace_ddl-function.patch | text/x-diff | 15.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-11-12 16:18:45 | Update timezone to C99 |
| Previous Message | Timur Magomedov | 2025-11-12 16:11:51 | Re: [WIP]Vertical Clustered Index (columnar store extension) - take2 |