| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Vaibhav Dalvi <vaibhav(dot)dalvi(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add pg_get_subscription_ddl() function |
| Date: | 2025-11-12 10:49:22 |
| Message-ID: | 202511121044.pw34gsirtu2s@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
If build_subscription_ddl_string is "internal" as its comment claims,
why is it declared extern in ruleutils.h? I think it should be a static
function instead. If you want to make it extern, it should live in
src/backend/catalog/pg_subscription.c and its prototype in
src/include/catalog/pg_subscription.h. And if you do move it to
pg_subscription.c (but I don't necessarily agree with that), then you
don't need a third copy of textarray_to_stringlist.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-11-12 10:49:36 | Re: Make PQgetResult() not return NULL on out-of-memory error |
| Previous Message | Thomas Munro | 2025-11-12 10:47:16 | Re: Trying out read streams in pgvector (an extension) |