| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Mats Kindahl <mats(dot)kindahl(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Refactor StringInfo usage in subscriptioncmds.c |
| Date: | 2025-11-06 12:40:18 |
| Message-ID: | 202511061224.qwx6pqiyiwku@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Nov-06, Mats Kindahl wrote:
> Attached is a proposal that instead of building error message and hints
> dynamically, it will use ereport() directly and as a result does not have to
> allocate the error message strings and error message hints dynamically and
> these can be removed.
LGTM, thanks.
I agree with Amit that there doesn't seem to be a need to free
pubnames.data. We're already leaking publist, for instance. This is
okay since we only call these functions during DDL, which in general is
not sensitive to leaks.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Small aircraft do not crash frequently ... usually only once!"
(ponder, http://thedailywtf.com/)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2025-11-06 12:46:01 | Re: [PATCH] Fix orphaned backend processes on Windows using Job Objects |
| Previous Message | Mats Kindahl | 2025-11-06 12:34:54 | Re: Refactor StringInfo usage in subscriptioncmds.c |