Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Manni Wood <manni(dot)wood(at)enterprisedb(dot)com>, Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Date: 2025-11-04 19:26:48
Message-ID: 202511041925.vylrdmncwfxg@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Nov-04, Jim Jones wrote:

> That's the way I see it too. Of course it's always easier to use the
> tablespace's name, but there might be cases where you only have the oid
> -- in which case you'd need to do a JOIN with pg_tablespace to find the
> name. It's just for convenience.

The other DDL-producing patches that are being posted, all depend on a
reg* type for their argument, which means they will work correctly with
either an OID or an object name. Tablespaces are one of the few object
types for which no "regtablespace" exists, so I think it's fair to
require both forms.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
[…] indem ich in meinem Leben oft an euch gedacht, euch glücklich zu machen. Seyd es!
A menudo he pensado en vosotros, en haceros felices. ¡Sedlo, pues!
Heiligenstädter Testament, L. v. Beethoven, 1802
https://de.wikisource.org/wiki/Heiligenstädter_Testament

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-11-04 19:27:52 Re: PG18 GIN parallel index build crash - invalid memory alloc request size
Previous Message Paul A Jungwirth 2025-11-04 19:12:46 Re: SQL:2011 Application Time Update & Delete