Re: pg_createsubscriber --dry-run logging concerns

On 2025-Nov-04, Peter Smith wrote:

> On Sat, Nov 1, 2025 at 5:02 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:

> > I'm not opposed to 0001 (to master only), but I think the lines of
> > dashes are a little excessively noisy. Are there other opinions on
> > that? Note that vacuumlo also has it, with no dashes.
>
> It was intentionally "noisy" with dashes to make it impossible to
> accidentally overlook dry-run mode in the logs. But if that's contrary
> to the way Postgres does things I am fine if you want to remove the
> dashes.

Yeah, I don't know if it's The Postgres Way or just accidental, but I'd
rather stay away from that kind of noise. Also, from a i18n point of
view, the lines of dashes (as implemented here) would get in the message
catalogs, which nobody will appreciate. Please do make the messages a
single string rather than two separate strings though, perhaps with an
embedded newline if more than one line of output is needed.

> I took a quick look at your follow-up patches and below are some comments:

Thanks for looking at them. I pushed 0002; I'm waiting on the CI run
https://cirrus-ci.com/build/5618025065349120
to push 0001.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/