Re: List TAP test files in makefiles

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: List TAP test files in makefiles
Date: 2025-10-31 16:15:14
Message-ID: 202510311607.3nqfh23kpnyv@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Oct-28, Michael Paquier wrote:

> IMO, we should tackle this problem the other way around: what would it
> take to have meson build a list of the TAP files in t/ based on an
> automated rule when tests.tap is defined?

Maybe what we need is a single source of truth that is used both by
Makefiles and meson: say, a file named "testlist" which contains lines
like

regress = foo bar baz
tap = t/001_foo.pl t/002_bar.pl

(possibly with backslash-escaped newlines) and so on, which is processed
by each build system in the way that it needs. This way, whichever
system is used by a developer, either the test will run because they
changed this one file, or it won't.

I don't know how much scaffolding is needed to make this work, but I
don't think it would be too bad.

IIRC Andres has complained about the Makefiles using t/*.pl to determine
the tests to run. This would also solve that problem.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"I suspect most samba developers are already technically insane...
Of course, since many of them are Australians, you can't tell." (L. Torvalds)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2025-10-31 16:15:28 Re: Fully documenting the design of nbtree row comparison scan keys
Previous Message Marcus Gartner 2025-10-31 16:04:35 [PATCH] Fix LTREE subpath with negative offset