| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, andrewbille(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases |
| Date: | 2025-10-18 16:22:16 |
| Message-ID: | 202510181619.crppv2bdx2xm@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2025-Oct-06, Dilip Kumar wrote:
> I think we can fix it in getTableAttrs(), see attached, with that I
> can see my dump is correct. This is just a quick way to show what I
> am thinking, maybe we can improve this condition.
Pushed, thanks. I added a test so that cross-version upgrade will hit
this. Because this code is not used except when upgrading from 17 or
older, I had to modify 17 even though that version needs no code changes
itself. (I verified that the pg_upgrade test fails if I have this table
in a pg_dumpall from version 17 -- and the diff is exactly this missing
NOT NULL constraint.)
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-10-18 16:45:45 | Re: Issues with blocksize smaller than 8KB |
| Previous Message | Álvaro Herrera | 2025-10-18 12:06:56 | Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases |