| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | li(dot)evan(dot)chao(at)gmail(dot)com |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pramsey(at)cleverelephant(dot)ca, ojford(at)gmail(dot)com, peter(at)eisentraut(dot)org, krasiyan(at)gmail(dot)com, vik(at)postgresfriends(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-10-14 10:21:13 |
| Message-ID: | 20251014.192113.1554227757626092006.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>> I overlooked the elog() call and "own implementation of
>>>> get_func_name()". Will fix.
>>>
>>> Attached is a trivial patch to fix that. I am going to push it if
>>> there's no objection.
>>>
>>> Best regards,
>>> --
>>> Tatsuo Ishii
>>> SRA OSS K.K.
>>> English: http://www.sraoss.co.jp/index_en/
>>> Japanese:http://www.sraoss.co.jp
>>> <v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch>
>>
>>
>> I just take a quick look at the patch, a tiny comment is:
>>
>> ```
>> + char *funcname = get_func_name(fcinfo->flinfo->fn_oid);
>> ```
>>
>> This can be a “const char *”.
>
> Thanks for the review. In addition to the point, I added an assertion
> which is called by all other window function API. Also added check to
> the return value of get_func_name() because it could return NULL. V2
> patch attached.
V2 patch pushed. Thanks.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matěj Klonfar | 2025-10-14 11:13:38 | [PROPOSAL] comments in repl_scanner |
| Previous Message | Amit Kapila | 2025-10-14 10:06:34 | Re: Logical Replication of sequences |