| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended |
| Date: | 2025-10-08 16:56:58 |
| Message-ID: | 202510081649.7wi7elzjuokz@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Oct-08, Masahiko Sawada wrote:
> I noticed we're currently hardcoding the "BUFFER_USAGE_LIMIT" option
> name in the error message:
>
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("BUFFER_USAGE_LIMIT option must be 0 or between %d kB
> and %d kB",
> MIN_BAS_VAC_RING_SIZE_KB, MAX_BAS_VAC_RING_SIZE_KB),
> hintmsg ? errhint("%s", _(hintmsg)) : 0));
>
> Should we also change this for consistency with how we handle other
> VACUUM options?
I would appreciate that, and also a change there from errhint() to
errhint_internal.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Los dioses no protegen a los insensatos. Éstos reciben protección de
otros insensatos mejor dotados" (Luis Wu, Mundo Anillo)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-10-08 17:06:22 | Re: Add memory_limit_hits to pg_stat_replication_slots |
| Previous Message | Nathan Bossart | 2025-10-08 16:50:34 | Re: [PATCH] Remove unused #include's in src/backend/commands/* |