Re: git head build failure

Hello,

On 2025-Oct-07, Devrim Gündüz wrote:

> My daily alpha RPMs failed to build in the last 2 days. Using the
> tarball here:
>
> https://ftp.postgresql.org/pub/snapshot/dev/
>
>
> This happens on all of my RHEL/Fedora boxes (gcc 8.5.0 to 15.2.1) (clang 19 to clang 21):
> =======================================
> /usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-format-truncation -O2 -I. -I. -I../../src/include -D_GNU_SOURCE -I/usr/include -I/usr/include/libxml2 -DWITH_GZFILEOP -flto=thin -emit-llvm -c -o funcs.bc funcs.c
> funcs.c:74:35: error: call to undeclared function 'VARSIZE_ANY_EXHDR'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 74 | text *new_t = (text *) palloc(VARSIZE_ANY_EXHDR(t) + VARHDRSZ);
> | ^

Thanks for reporting. I'm going to bet that this is related to the
recent header inclusion changes I did two days ago, but I wonder why
don't I see them ...

... oh, this file is in src/tutorial/. I can find no Makefile rule that
compiles these files -- in fact, its own Makefile doesn't even work
under VPATH, and Meson has never heard of them (so I had to create a
separate workdir in order to test the fix, because none of my existing
trees are capable of compiling these files). So if this code wasn't
referenced from the documentation, it would all be pretty much dead
code. I wonder if anyone other than ancient forgotten RPM .spec files
compiles these files anymore.

Anyway, I've fixed it now, thanks for reporting.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"El miedo atento y previsor es la madre de la seguridad" (E. Burke)