| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | ojford(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, krasiyan(at)gmail(dot)com, vik(at)postgresfriends(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-10-06 00:28:13 |
| Message-ID: | 20251006.092813.1105116428701000307.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Looking around, there is only one in-core caller of
> WinGetFuncArgInPartition, and it does pass a valid "isout" pointer,
> explaining why this inconsistency wasn't obvious in testing.
> There are outside callers though according to Debian Code Search,
> and at least PostGIS is one that passes a null pointer.
>
> As Alvaro notes nearby, this function is ridiculously complicated
> already. I'm tempted to remove the API allowance for isout == NULL,
> and thereby simplify the code slightly, rather than complicate it more
> by continuing to allow that. We'd have to warn the PostGIS people
> about the API change though.
It think it's a good idea.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Wienhold | 2025-10-06 00:40:31 | Re: psql: Count all table footer lines in pager setup |
| Previous Message | Tatsuo Ishii | 2025-10-06 00:09:01 | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |