Re: Suggestion to add --continue-client-on-abort option to pgbench

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Date: 2025-09-30 06:16:53
Message-ID: 20250930151653.de1d1864fc1d743fc3e45f45@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 30 Sep 2025 13:46:11 +0900
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Tue, Sep 30, 2025 at 10:24 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > Fujii-san, thank you for committing the patch that fixes the assertion failure.
> > I've attached the remaining patches so that cfbot stays green.
>
> Thanks for reattaching the patches!
>
> For 0001, after reading the docs on PQresultErrorMessage(), I wonder if it would
> be better to just use that to get the error message. Thought?

Thank you for your suggestion.

I agree that it is better to use PQresultErrorMessage().
I had overlooked the existence of this interface.

I've attached the updated patches.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
v16-0003-pgbench-Improve-error-messages-for-errors-that-c.patch text/x-diff 3.0 KB
v16-0002-pgbench-Add-continue-on-error-option.patch text/x-diff 14.9 KB
v16-0001-pgbench-Use-PQresultErrorMessage-instead-of-PQer.patch text/x-diff 2.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-09-30 06:26:14 Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Previous Message John Naylor 2025-09-30 06:05:42 Re: GB18030-2022 Support in PostgreSQL