| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, kristianlejao(at)gmail(dot)com |
| Subject: | Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c |
| Date: | 2025-09-26 13:34:38 |
| Message-ID: | 202509261330.5acuwmf57rvu@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2025-Sep-24, Etsuro Fujita wrote:
> I took a quick glance at the patch. My initial comment is: it only
> includes the test case discussed here, but I think it's a good idea to
> add more cases in it (that exercise code paths in
> postgresRecheckForeignScan), as I mentioned upthread. What do you
> think about that? If no objections, I'd like to update it to include
> such cases.
I would like to suggest a different approach: because this patch is
known to fix a server crash in a known case, it would be better to get
the fix (and its corresponding test) pushed as is without further delay.
Additional tests are an excellent idea, but I think we shouldn't make
this patch wait for them. If further fixes are deemed necessary for
those other (thus far hypothetical) tests, we can still make them
afterwards.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthony Sotolongo | 2025-09-26 13:35:50 | Re: BUG #19064: Trigger allows creation with invalid column references but fails at runtime |
| Previous Message | Rahila Syed | 2025-09-26 12:59:45 | Re: BUG #19064: Trigger allows creation with invalid column references but fails at runtime |