Re: refactor backend type lists

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Jonathan Abdiel Gonzalez Valdebenito <jonathan(dot)abdiel(at)gmail(dot)com>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: refactor backend type lists
Date: 2025-09-26 12:28:52
Message-ID: 202509261223.u25cgqap6xda@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Sep-18, Jonathan Abdiel Gonzalez Valdebenito wrote:

> The call to gettext_noop() was missing, hence, the translation for the
> backends was missing. I've attached a third commit to your patch
> adding the missing gettext_noop() and also adding the include
> directory to the nls.mk Makefile which will add proctypelist.h to the
> list of files used to generate the po.

Thank you, that makes sense. CI says that we still have problems in
mingw32 cross-compile apparently because of 0002, so I decided to ditch
it for now (it's non-essential anyway). Another failure is `make
headerscheck`, which hopefully I've fixed her: just tell it to skip this
file. Here's v4, which I would push right away except I want to see
if CI now turns green.

We can pursue 0002 later, if anybody feels the motivation to do so. I
think it'd be a good idea.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Ed is the standard text editor."
http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3

Attachment Content-Type Size
v4-0001-Create-a-separate-file-listing-backend-types.patch text/x-diff 9.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Pogrebnoi 2025-09-26 12:33:22 Re: Panic during xlog building with big values
Previous Message Álvaro Herrera 2025-09-26 11:55:50 splitting src/bin/scripts/vacuumdb.c