| From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Date: | 2025-09-26 01:29:32 |
| Message-ID: | 20250926102932.617a80a1f2fdd2b221c4d7d4@sraoss.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 26 Sep 2025 00:03:06 +0900
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Sep 25, 2025 at 4:22 PM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > I've attached updated patches.
>
> Thanks for updating the patches!
>
> About 0001: you mentioned that the lost error message issue occurs in
> pipeline mode.
> Just to confirm, are you sure it never happens in non-pipeline mode?
> From a quick look,
> readCommandResponse() seems to have this problem regardless of whether pipeline
> mode is used.
>
> If it can also happen outside pipeline mode, maybe we should split this from
> the assertion failure fix, since they'd need to be backpatched to
> different branches.
I could not find a code path that resets the error state before reporting in
non-pipeline mode, since it is typically reset when starting to send a query.
However, referencing an error message after another PQgetResult() does not seem
like a good idea in general, so I agree with splitting the patch.
I'll submit updated patches soon.
Regards,
Yugo Nagata
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-09-26 01:40:56 | Re: plan shape work |
| Previous Message | Chao Li | 2025-09-26 01:24:03 | Re: Remove unused for_all_tables field from AlterPublicationStmt |