| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | ojford(at)gmail(dot)com, peter(at)eisentraut(dot)org |
| Cc: | li(dot)evan(dot)chao(at)gmail(dot)com, krasiyan(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, vik(at)postgresfriends(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-09-24 13:18:42 |
| Message-ID: | 20250924.221842.203240336888394367.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Oliver,
> On Wed, Sep 24, 2025 at 6:39 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
>> I tried to change all "int ignore_nulls;" to "uint8 ignore_nulls;" but
>> gen_node_support.pl dislikes it and complains like:
>>
>> could not handle type "uint8" in struct "FuncCall" field "ignore_nulls"
>>
>>
> uint8 was missing in one place in that perl script. The attached patch
> silences it for uint8/uint16.
Thank you for the patch. (I noticed int8 is also missing).
I have looked into the commit 964d01ae90c3 which was made by Peter. I
have quick read through the discussion to know why uint8/uint16 (and
int8) are missing in gen_node_support.pl. Unfortunately I have no
clear idea why these data types are missing in the script.
Peter,
Maybe you wanted to limit the data types that are actually used at
that point? If so, probably we should only add uint8 support this time
(uint8 is only needed to implement $Subject for now). What do you
think?
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Timur Magomedov | 2025-09-24 13:47:37 | Re: [WIP]Vertical Clustered Index (columnar store extension) - take2 |
| Previous Message | Bertrand Drouvot | 2025-09-24 13:13:10 | Re: Report bytes and transactions actually sent downtream |