Re: waiteventset.c XXX

On 2025-Sep-18, Robert Haas wrote:

> I submit that we should not have both a comment that says we must save
> and restore errno and code that doesn't. Maybe the comment is intended
> to imply that the caller should be doing such a save and restore, but
> if so, then (a) that's not very clear from the wording and (b) why the
> XXX?

I understand the comment as saying that the caller should do
save/restore of errno. However, looking at several places that are
calling SetLatch() (which is the only caller of this function) it
appears that at least several of them have actually forgotten to do so
(didn't scan all of them but checked a couple and they weren't doing
it). I think what you have found is not just a bogus comment, but an
actual bug or class of bugs.

I think your contact list has an outdated address for Heikki, or at
least one he hasn't used in a very long time.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)