From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Reword messages using "as" instead of "because" |
Date: | 2025-09-16 02:46:44 |
Message-ID: | 20250916.114644.275726106301941878.horikyota.ntt@gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello.
I noticed that the recent commit 0d48d393d46 introduced the following
three messages:
4793> errdetail("Retention is stopped as the apply process is not advancing its xmin within the configured max_retention_duration of %u ms.",
4822> ? errdetail("Retention is re-enabled as the apply process is advancing its xmin within the configured max_retention_duration of %u ms.",
4824> : errdetail("Retention is re-enabled as max_retention_duration is set to unlimited."));
I think I saw other instances of this kind of as recently, and I
thought we had agreed to avoid this usage and prefer because instead,
but I lost track of where that discussion took place.
Anyway, unlike some past uses, these ones are apparently confusing,
and I'd like to propose changing the wording to because.
In addition, I felt that the tense in the second message is not
immediately clear. If it is reasonable and keeps the correct sense,
I'd like to propose changing "is (not) advancing its xmin within" to
"has (not) advanced its xmin into".
+ errdetail("Retention is stopped because the apply process has not advanced its xmin into the configured max_retention_duration of %u ms.",
+ ? errdetail("Retention is re-enabled because the apply process has advanced its xmin into the configured max_retention_duration of %u ms.",
+ : errdetail("Retention is re-enabled because max_retention_duration is set to unlimited."));
I'm not sure this is worth fixing, but anyway the proposed patch is
attached.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
0001-Reword-recently-introduced-messages.patch | text/x-patch | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Zhijie Hou (Fujitsu) | 2025-09-16 03:53:38 | RE: Conflict detection for update_deleted in logical replication |
Previous Message | Michael Paquier | 2025-09-16 02:29:58 | Re: question about pending updates in pgstat_report_inj |